feat(session_store): can logout session after n seconds - #1194
Merged
Conversation
fbacall
requested changes
Dec 16, 2025
Member
There was a problem hiding this comment.
I don't think this test is needed.
Also I'm slightly worried that loading that initializer will impact the rest of the test suite somehow.
| if Rails.env.production? | ||
| opts = { same_site: :lax, secure: true } | ||
| expiry_time = TeSS::Config.login_expires_after | ||
| opts[:expire_after] = expiry_time unless expiry_time.nil? |
Member
There was a problem hiding this comment.
I think change the nil check to expiry_time.blank? instead, just to be safe
fbacall
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
expire_afterthroughTeSS::Config.login_expires_afterintess.example.ymlMotivation and context
Security reasons, backed up by https://guides.rubyonrails.org/security.html#session-expiry
Checklist
to license it to the TeSS codebase under the
BSD license.